- Solution match the problem
- Explain the change to the reviewer
- Does the change solve the problem?
- Is the change consistent with the existing architecture and design?
- Is the code easy to understand?
- Naming
- Class, method size
- Single Responsibility per class
- Has it been tested?
- Automated tests & test coverage
- Do a quick manual test
- Has the technical debt increased?
- If, yes, where is it documented and who has approved it?
Labels:
None
1 Comment
comments.show.hideMar 23, 2013
Erik Drolshammer
http://lars-lab.jpl.nasa.gov/JPL_Coding_Standard_Java.pdf